Optimize gemv forwarding on ARM64 systems #4955
Merged
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mousius
approved these changes
Oct 25, 2024
Contributor
Mousius
left a comment
Mousius
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for removing the gotos 😸
Collaborator
|
Thank you (both), merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a modified version of the optimization mentioned in issue #4951. The code now avoids goto statements. The code now also only restricts the gemv forwarding on ARM64 systems since this is where we observed poor gemv performance.