Skip to content

Pydantic error handling #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 16, 2025
Merged

Pydantic error handling #549

merged 3 commits into from
Jan 16, 2025

Conversation

zain-sohail
Copy link
Member

closes #544

@zain-sohail zain-sohail changed the base branch from main to v1_feature_branch January 13, 2025 00:05
@zain-sohail zain-sohail requested a review from rettigl January 13, 2025 00:05
rettigl
rettigl reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe just adding a logger mesage is sufficient, rather than creating a new error type.
You can also use a ValueError with from e

@coveralls
Copy link
Collaborator

coveralls commented Jan 14, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12798915516

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 92.131%
Files with Coverage Reduction New Missed Lines %
src/sed/binning/numba_bin.py 3 87.62%
Totals Coverage Status
Change from base Build 12798864009: -0.04%
Covered Lines: 7692
Relevant Lines: 8349
💛 - Coveralls

@zain-sohail zain-sohail requested a review from rettigl January 15, 2025 23:34
@rettigl rettigl merged commit 1752d34 into v1_feature_branch Jan 16, 2025
4 checks passed
@rettigl rettigl deleted the pydantic-error-handling branch January 16, 2025 14:41
@zain-sohail zain-sohail mentioned this pull request Jan 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rettigl rettigl rettigl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw a better error pydantic
3 participants
@zain-sohail @coveralls @rettigl