Skip to content

add failing test for empty body for 204 response #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gustavnikolaj wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add failing test for empty body for 204 response #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions test/Teepee.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1425,6 +1425,28 @@ describe('Teepee', function () {
new Teepee('http://localhost:5984/').request('foo', cb);
}, 'to call the callback with error', new HttpError.BadGateway('Error parsing JSON response body'));
});

it('should not attempt to parse json when the status is 204 and the body is empty', function () {
var responseStream = new stream.Readable();
responseStream._read = function () {
responseStream.push(null);
};

httpception({
request: 'GET http://localhost:5984/foo',
response: {
statusCode: 204,
headers: {
'Content-Type': 'application/json'
},
body: responseStream
}
});

return expect(function (cb) {
new Teepee('http://localhost:5984/').request('foo', cb);
}, 'to call the callback without error');
});
});

describe('with a query', function () {
Expand Down