-
Notifications
You must be signed in to change notification settings - Fork 171
Add OWASP Juice Shop metadata #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated on 2025-10-05 by Arkadii Yakovets as part of the OWASP Schema initiative within OWASP Nest. Repository: `OWASP/www-project-juice-shop` Co-authored-by: Arkadii Yakovets <[email protected]>
|
I would not want to have to maintain this schema file alongside our existing |
bkimminich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see previous two comments.
|
@arkid15r, please take a look at my comments and provide feedback. I'm not merging something so clearly AI generated and not humanly curated. The maintenance follow-up work is unclear and I'm not sure if there will be loss of information or duplication of content on some scale. cc/ @mamicidal |
|
@bkimminich I'm assuming positive intent, but I'd like to ask to refrain from commenting on areas they don't fully understand, including the scope of work already completed or still WIP. Nobody likes duplicated effort but here I am answering your questions both here and on Slack because I have a goal and want to see it completed. Here are some links to work that has clearly been AI-generated and not humanly curated:
I'm not going to push anyone into doing something they don't want to as project leaders. |
|
Hi @arkid15r! I have updated the YAML in this PR to contain every information that Juice Shop needs. This fails the schema validation of course, as some fields or enum values are missing:
I will merge the PR now anyhow and propose a change to the NEST schema afterwards. |
(to accomodate needs of OWASP Juice Shop; see OWASP/www-project-juice-shop#16 (comment))
* Extend license, community, and social_media enums (to accomodate needs of OWASP Juice Shop; see OWASP/www-project-juice-shop#16 (comment)) * Make new enum entries known in test cases * Honor line length restrictions * Cut lines more strictly * Apply missing enum changes * Remove trailing comma * Update code --------- Co-authored-by: Arkadii Yakovets <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]>
|
@bkimminich thanks for merging this 👍 |

OWASP Entity Information
OWASP/www-project-juice-shopChanges
This PR adds the project data to comply with the OWASP Schema specification. The changes include:
Purpose
This addition ensures that the project data follows the standardized OWASP Schema format, enabling:
Review Guidelines
When reviewing this PR, please focus on:
Support & Questions
If you have any questions about this PR or the OWASP Schema implementation:
Closes OWASP/nest-schema#140