Fix archiver for issue #358 #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test should cover issue OPMDG#358
Member
yeah, I suppose we need the actual fix to keep thee checks green :) |
Member
Author
gleu
reviewed
Nov 5, 2025
t/01-archiver.t
Outdated
Comment on lines
163
to
164
| skip "checking with non superuser role is not supported before v10", 4 | ||
| if $node->version < '9.4'; |
Collaborator
There was a problem hiding this comment.
Should be < '10' according to the message.
Collaborator
|
I took a look at the code, and except the test, it looks fine to me. |
Per report from Guillaume Lelarge.
Member
Author
|
Thanks for the review. |
Member
Author
|
@ioguix do you want to take a look or can I merge this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test should cover issue #358
Please wait a bit before applying this PR.