Expand Locale parser to support three-character language codes #6124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Community
nkolev92
reviewed
Oct 29, 2024
baronfel
force-pushed
the
support-three-character-locale-prefixes
branch
from
7c3e4a0 to
3cf400c
Compare
…three-letter locales
baronfel
force-pushed
the
support-three-character-locale-prefixes
branch
from
3cf400c to
d0a4d36
Compare
baronfel
commented
Oct 29, 2024
nkolev92
previously approved these changes
Oct 29, 2024
baronfel
commented
Oct 30, 2024
src/NuGet.Core/NuGet.Packaging/ContentModel/ManagedCodeConventions.cs
Outdated
Show resolved
Hide resolved
nkolev92
approved these changes
Oct 30, 2024
|
@baronfel What .NET SDK version did this make it into? |
Contributor
Author
|
9.0.200+ for sure, perhaps 9.0.100 but I'm not certain given the backport bar... |
Member
|
Issue says 6.13, so that's 9.0.200 https://learn.microsoft.com/en-us/nuget/release-notes/nuget-6.13 |
|
Fantastic, thank you. I've been preparing to release Humanizer 3.0 -- an RC is currently live now -- and I added the fil locale back into the default metapackage. I'll give it a go on SDK 8 and see if/how it breaks 😅. What is the current story with the .NET Framework version of MSBuild w.r.t. NuGet client versions? I'm trying to understand the potential impact of this as I do not want to suddenly break people! :) |
Member
|
17.13 and newer should have this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12253
Description
Per NuGet/Home#12253 (comment), I found that all cultures known to .NET on my Windows and Linux hosts used 2 or 3-character language codes, so I expanded the heuristic in the
Locale_Parserto this to enable handling of resources for these locales in .NET packages. I also added comments explaining why these decisions were made and a note about future fully-correct implementations if those become required.PR Checklist