Skip to content

refactor(js-x-ray)!: migrate to TypeScript #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

refactor(js-x-ray)!: migrate to TypeScript #364

merged 3 commits into from
Jun 30, 2025

Conversation

fraxken
Copy link
Member

@fraxken fraxken commented Jun 29, 2025

No description provided.

Copy link

changeset-bot bot commented Jun 29, 2025

⚠️ No Changeset found

Latest commit: e5941e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fraxken fraxken force-pushed the migrate-ts branch 2 times, most recently from 27e86fb to 178f226 Compare June 30, 2025 12:46
@fraxken fraxken marked this pull request as ready for review June 30, 2025 12:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request refactors the JS-X-Ray codebase to TypeScript, updating file types, adding explicit TS annotations, and migrating many helper tests and utilities. Key changes include converting JavaScript source files and tests to TypeScript, integrating stricter typing (e.g. via explicit interfaces and type assertions), and adjusting build and test scripts in package.json.

Reviewed Changes

Copilot reviewed 72 out of 98 changed files in this pull request and generated 3 comments.

File Description
workspaces/ts-source-parser/package.json Updated build/test scripts for TypeScript compilation and execution.
workspaces/sec-literal/test/*.ts Added TS-specific comments (e.g. @ts-expect-error) to suppress intentional type errors.
workspaces/js-x-ray/src/**/*.ts & test files Migrated core source files and tests from JS to TS with added type annotations and improved type safety.
workspaces/js-x-ray/package.json Updated exports and build scripts to point to compiled TS output in the dist folder.

@fraxken fraxken force-pushed the migrate-ts branch 2 times, most recently from b1758cc to f24215f Compare June 30, 2025 13:03
@fraxken fraxken merged commit 3c2d35a into master Jun 30, 2025
6 checks passed
@fraxken fraxken deleted the migrate-ts branch June 30, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants