protoc-gen-grpc-web: init at 1.2.1

[06kellyjac]

Motivation for this change

Init protoc-gen-grpc-web at 1.2.1

Using a patch from grpc/grpc-web#1107

Is there a better way to change dir or to fetchFromGithub and only keep the ./javascript/net/grpc/web/ subdir? thanks

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Relase notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[alyssais]

When cross-compiling (building pkgsCross.aarch64-multiplatform.protoc-gen-grpc-web), I got this error:

aarch64-unknown-linux-gnu-g++ -std=c++11 -I/usr/local/include -pthread  -c -o grpc_generator.o grpc_generator.cc
grpc_generator.cc:19:10: fatal error: google/protobuf/compiler/code_generator.h: No such file or directory
   19 | #include <google/protobuf/compiler/code_generator.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [<builtin>: grpc_generator.o] Error 1

So protobuf needs to be a (non-native) build input. You might want to set strictDeps = true; to help catch this sort of issue when not cross-compiling.

[06kellyjac]

Thanks for the reviews

[alyssais]

aarch64-unknown-linux-gnu-g++ -std=c++11 -I/usr/local/include -pthread  -c -o grpc_generator.o grpc_generator.cc
grpc_generator.cc:19:10: fatal error: google/protobuf/compiler/code_generator.h: No such file or directory
   19 | #include <google/protobuf/compiler/code_generator.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [<builtin>: grpc_generator.o] Error 1

So protobuf needs to be both a build input and a native build input.