This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Consolidates restricted visibility-based filtering #995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevgliss
approved these changes
Mar 26, 2021
| query = db_session.query(model_cls) | ||
|
|
||
| if user_role != UserRoles.admin.value: | ||
| if model.lower() == "incident": |
Contributor
There was a problem hiding this comment.
Do we need to do something similar for tasks for restricted incidents?
Contributor
Author
There was a problem hiding this comment.
I was going to add logic for it, but when I started testing tasks I realized they were already being filtered. I did some research to try to figure out the why and the conclusion that I reached was that when we load /tasks we perform a GET against the /api/v1/incidents/ endpoint, which returns a list of filtered incidents, and then sqlalchemy filters out the tasks based on that list.
|
This pull request introduces 4 alerts when merging 7e73d9d into b8b876c - view on LGTM.com new alerts:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.