This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(ui): fixes edit pane on case type #5507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Offiong Aniekanabasi <[email protected]> Signed-off-by: David Whittaker <[email protected]>
metroid-samus
approved these changes
Dec 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with the edit pane in the case type UI. The changes ensure that the project and incident project are correctly fetched and assigned, and updates the way project IDs are handled across different components.
Changes
The main changes include:
NewEditSheet.vue:projectandincidentProjectwithin thecreatedlifecycle hook. The code now correctly fetches and assigns the project data fetched from the API.IncidentTypeSelect.vue:project_idassignment, ensuring that the correct project is always applied.ServiceSelect.vue:project_idin filter options, changing it from a map operation to direct access, which is more efficient and accurate.createParametersFromTableOptionsto specify context.Previous behavior
Screen.Recording.2024-11-20.at.5.34.16.PM.mov