This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Removes option to delete a signal definition #5471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitdog47
approved these changes
Nov 13, 2024
mvilanova
deleted the
feat/removes-signal-definition-ui-delete-option
branch
mvilanova
added a commit
that referenced
this pull request
Nov 14, 2024
This reverts commit a557071.
mvilanova
added a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Backend -
service.pyandviews.py:deletefunction inservice.py, which previously handled deletion of signal definitions.delete_signalendpoint inviews.py, including the associated permission check for deleting signals.Frontend - Vue Components:
DeleteDialog.vue: Removed entirely. This file previously handled the delete confirmation dialog for signals.Table.vue:<delete-dialog />component reference from the template.DeleteDialog.These modifications effectively remove the signal deletion functionality from both the backend and frontend.