This repository was archived by the owner on Sep 3, 2025. It is now read-only.
ui(mfa): dont require button click to validate mfa, do automatically #5448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssheldon
added
enhancement
kevgliss
approved these changes
Nov 8, 2024
Contributor
kevgliss
left a comment
kevgliss
left a comment
There was a problem hiding this comment.
lgtm, aligns with how stairmaster does it as well.
wssheldon
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove button you have to click on
/mfato complete the flow.Clicking the button to validate MFA is unnecessary, being able to navigate to the page is enough.
How did you verify your code works?
I wrote component level tests.
✓ src/tests/Mfa.spec.js (6) ✓ mounts correctly and starts verification automatically ✓ shows loading state while verifying ✓ shows success message and closes window on approval ✓ shows error message and retry button on denial ✓ retry button triggers new verification attempt ✓ handles API errors gracefully Test Files 1 passed (1) Tests 6 passed (6) Start at 09:11:58 Duration 391msI manually test the new flow, end to end.