This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Only display active roles in CaseParticipantsTab component, add Vitest, and unit test(s) #2960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssheldon
added
enhancement
wssheldon
commented
Feb 8, 2023
wssheldon
commented
Feb 8, 2023
Contributor
Author
|
@kevgliss @mvilanova Any opinions on where the tests for front-end should be stored? Here they are stored in the static/ dir and E2E tests are currently in the gitroot tests/ dir. Which do you prefer? |
kevgliss
reviewed
Feb 8, 2023
mvilanova
reviewed
Feb 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents renounced roles from being displayed in the CaseParticipantsTab component. Previously, when someone has frequently changed roles, their roles will appear as `('Reporter', 'Assignee', 'Participant', 'Assignee'), for example. We only display roles that haven't been renounced and add support for testing Vue 2 components with Vitest [0]. Finally, we add a unit test for this specific case and others for the CaseParticipantsTab component.
✓ tests/participants-tab.spec.js (2) Test Files 1 passed (1) Tests 2 passed (2) Start at 08:36:41 Duration 778ms (transform 211ms, setup 0ms, collect 191ms, tests 14ms) PASS Waiting for file changes... press h to show help, press q to quit[0] https://vitest.dev/