-
Notifications
You must be signed in to change notification settings - Fork 629
tests/end-to-end-test-for-report-submission-using-playwright-in-ci #2936
Conversation
|
I think you should be able to run these via a github action: Authentication wise we should be able to leverage basic auth with the default user. |
I think I'll need to use the |
| ) | ||
| ) | ||
| .toBeVisible() | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to extend this test to validate the submission report card has not regressed in anyway. This pattern will probably come up a lot and it feels very verbose and maybe flakey to do it this way. Maybe a todo could be to investigate using something like this: https://www.thoughtworks.com/en-us/radar/techniques/component-visual-regression-testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "resolved": "https://registry.npmjs.org/@types/node/-/node-18.11.7.tgz", | ||
| "integrity": "sha512-LhFTglglr63mNXUSRYD8A+ZAIu5sFqNJ4Y2fPuY7UlrySJH87rRRlhtVmMHplmfk5WkoJGmDjE9oiTfyX94CpQ==", | ||
| "dev": true, | ||
| "peer": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why that changed
|
|
||
| async function login(page: Page): Promise<void> { | ||
| let email = (Math.random() + 1).toString(36).substring(7) + "@example.com" | ||
| let password = (Math.random() + 1).toString(36).substring(7) |
Check failure
Code scanning / CodeQL
Insecure randomness
Tests work great locally, need to brainstorm how to fully automate authentication in CI, and how to run the development server in CI on GH Actions.
I recreated the bug where the "Load More" button did not appear for the Project select button, introduced here. The test will check for the "Load More" text and fail if it can't be found after selecting the
Typebutton, this failed as expected: