Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

Conversation

@kevgliss
Copy link
Contributor

No description provided.

@kevgliss kevgliss force-pushed the feature/user-engagement-filters branch 2 times, most recently from 98712e4 to 8094737 Compare April 28, 2021 18:49
@kevgliss kevgliss force-pushed the feature/user-engagement-filters branch from 7e06243 to b3e858d Compare April 29, 2021 23:34
@kevgliss kevgliss marked this pull request as ready for review April 29, 2021 23:35
@kevgliss kevgliss requested a review from mvilanova April 29, 2021 23:35
@lgtm-com
Copy link

lgtm-com bot commented Apr 30, 2021

This pull request introduces 1 alert and fixes 2 when merging b3e858d into 0cd92ce - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 2 for Signature mismatch in overriding method

Copy link
Contributor

@mvilanova mvilanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think I found all the obvious things. Lots of changes we will need to test thoroughly.

@Netflix Netflix deleted a comment from lgtm-com bot Apr 30, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Apr 30, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Apr 30, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Apr 30, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Apr 30, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Apr 30, 2021
@Netflix Netflix deleted a comment from lgtm-com bot Apr 30, 2021
@lgtm-com
Copy link

lgtm-com bot commented Apr 30, 2021

This pull request introduces 7 alerts and fixes 2 when merging 76d4310 into 7cb27a1 - view on LGTM.com

new alerts:

  • 6 for Unused import
  • 1 for Wrong name for an argument in a call

fixed alerts:

  • 2 for Signature mismatch in overriding method

@kevgliss kevgliss merged commit d9caea9 into master May 3, 2021
@kevgliss kevgliss deleted the feature/user-engagement-filters branch May 3, 2021 18:17
@lgtm-com
Copy link

lgtm-com bot commented May 3, 2021

This pull request introduces 7 alerts and fixes 2 when merging d03a257 into bb7e52c - view on LGTM.com

new alerts:

  • 6 for Unused import
  • 1 for Wrong name for an argument in a call

fixed alerts:

  • 2 for Signature mismatch in overriding method

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants