fix(InputValueSerializer): allow scalars to be assignable from class #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 12, 2023 15:08
coleturner
requested review from
gracecding,
spellew,
srinivasankavitha and
congotej
srinivasankavitha
approved these changes
May 12, 2023
| @@ -81,8 +81,10 @@ class InputValueSerializer(private val scalars: Map<Class<*>, Coercing<*, *>> = | |||
| return input | |||
| } | |||
|
|
|||
| if (input::class.java in scalars) { | |||
| return scalars.getValue(input::class.java).valueToLiteral(input) | |||
coleturner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1522
This change addresses an edge case in
InputValueSerializer, where an input object's class may be assignable from a scalar's class. For example, if I register myZoneIdscalar, and my input object is actually aZoneRegion extends ZoneId, our strict matching will not be able to parse this input object. With this change, the matching of scalars is opened up to allow input objects to match to scalars where the class is assignable.@srinivasankavitha any concerns about backwards compatibility here? I can only imagine if folks were using typeMapping in ways that aren't intended.