Skip to content

Periods in the ONT kitname are replaced by dashes in the samplesheet #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aanil merged 2 commits into from
Nov 5, 2025
Merged

Periods in the ONT kitname are replaced by dashes in the samplesheet #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da1b2a8
Periods in the ONT kitname are replaced by dashes in the samplesheet
aanil Nov 4, 2025
e5a963f
Merge branch 'master' into master
aanil Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions VERSIONLOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Scilifelab_epps Version Log

## 20251104.1

Update EPP for generating ONT samplesheets so that periods in the kitname are replaced by dashes.

## 20251023.2

Update ONT EPPs to use cloudant instead of couchdb
Expand Down
2 changes: 1 addition & 1 deletion scripts/generate_minknow_samplesheet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def generate_MinKNOW_samplesheet(process):

errors = []

lims_kit = process.udf["ONT prep kit"]
lims_kit = process.udf["ONT prep kit"].replace(".", "-")

ont_libraries = [art for art in process.all_outputs() if art.type == "Analyte"]
ont_libraries.sort(key=lambda art: art.id)
Expand Down