Network improvement #1272
Open
Network improvement #1272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Unfortunately, I can't merge this into the main branch until Nagios XI properly handles data or else existing graphs will become broken due to the change in the number of endpoints and the poor input parsing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Nagios team / @ne-bbahn ,
Could you please review my other merge request #1271 before looking at this one?
For these changes I created a new branch based on the ARM build so I could run tests; without that split I couldn’t get a working environment. Once my other merge request has been merged, the impact of this proposal will be minimal.
My changes are inspired by merge request #837. The only feature I haven’t included yet is duplex support; if you would like that, I can add it. My goal is to be able to see remotely which MTU and network speed are in use.
For the default values I used the official docs: https://psutil.readthedocs.io/en/latest/#psutil.net_if_stats