Add various strategies from :nbp to minimize different patterns. #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and line switches.
…-abspath Use realpath instead of abspath. r=gkw
nbp
approved these changes
Mar 20, 2017
Contributor
nbp
left a comment
nbp
left a comment
There was a problem hiding this comment.
Thanks for merging my previous pull request. I did not got the opportunity to test this pull request, but skimming through the file the changes looks good to me.
interestingness/diffTest.py
Outdated
|
|
||
| ''' | ||
| This file came from nbp's GitHub PR #2 for adding new Lithium reduction strategies. | ||
| https://github.com/MozillaSecurity/lithium/pull/2 |
Contributor
There was a problem hiding this comment.
I think the authorship is interesting for blaming ( :) ), but less interesting for documentation strings.
Maybe move this to a # comment, and add the following ''' comment:
'''
This test is made to minimize a test case by comparing a single binary with different command line arguments.
This can be used to isolate and minimize differential behaviour test cases.
'''
Contributor
Author
There was a problem hiding this comment.
Thanks! I added this (and tweaked the comments a little).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebased #2 by @nbp so please refer to that PR for the context. @nbp, you might want to take a look to see if anything stands out to you.