Fix incorrect context being used for suggestions (MC-278771) #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes MC-278771.
The overview of this issue is that
CommandDispatcher#getCompletionSuggestionsdoesn't provide the correctCommandContextto theCommandNodefor which it's listing suggestions from. This is an issue as some suggestions may be contextual and rely on previous arguments in the command tree. Currently the rootCommandContextis provided, this means that any redirect causes the incorrect context to be provided and thus anIllegalStateExceptionto be thrown as the argument cannot be found.The solution to this is to provide the correct
CommandContextBuilderin theCommandContextBuilder#findSuggestionContextmethod. This builder can then provide the correctCommandContextfor the respective command node.