Skip to content

Conversation

@bbb651
Copy link

@bbb651 bbb651 commented Nov 8, 2024

I'm working on changes to read{Int,Long,Float,Double} to make them less greedy and noitced some tests that should've failed.

I went through every try catch and verified try properly fails.

I'm working on changes to `read{Int,Long,Float,Double}` to make them
less greedy and noitced some tests that should've failed.

I went through every try catch and verified `try` properly `fail`s.
@bbb651
Copy link
Author

bbb651 commented Nov 8, 2024

I finished implementing my primitive parsing rework, making a PR is blocked on this. Is it ok to remove isAllowedNumber? There are at least a few usages of it, mainly in minecraft mods, I think it's quite unfortunate it was public in the first place (on that note, should isAsciiDigit be private?)

By the way, I noticed readBoolean uses readString() rather than readUnquotedString() directly, making it parse "true" and "false" in addition to true and false. Is this intended? It's untested and undocumented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant