I added option to disable command suggestions in chat :,) #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbxte
reviewed
Aug 7, 2021
src/main/java/meteordevelopment/meteorclient/mixin/CommandSuggestorMixin.java
Show resolved
Hide resolved
sbxte
suggested changes
Aug 7, 2021
| .build() | ||
| ); | ||
|
|
||
| private final Setting<Boolean> onRenderSuggestion = sgOverlay.add(new BoolSetting.Builder() |
Collaborator
There was a problem hiding this comment.
onRenderSuggestion makes no sense for a name.
noCommandSuggestions would be better.
Author
There was a problem hiding this comment.
Okay now it should be done
| return isActive() && noEatParticles.get(); | ||
| } | ||
|
|
||
| public boolean onRenderSuggestion() { |
sbxte
added a commit
to AntiCope/meteor-rejects
that referenced
this pull request
Aug 7, 2021
Taken from an unmerged pr MeteorDevelopment/meteor-client#1347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.