Skip to content

Move PSA headers to a new tf-psa-crypto directory #9247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ronald-cron-arm merged 12 commits into from
Jun 18, 2024
Merged

Move PSA headers to a new tf-psa-crypto directory #9247

ronald-cron-arm merged 12 commits into from
Jun 18, 2024

Conversation

@ronald-cron-arm
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm commented Jun 12, 2024 •
edited
Loading

Description

Repo split preparation, move PSA headers to a new tf-psa-crypto directory
Companion mbedtls-framework PR: Mbed-TLS/mbedtls-framework#26
Fix #9261

PR checklist

@ronald-cron-arm ronald-cron-arm added enhancement needs-ci Needs to pass CI tests component-psa PSA keystore/dispatch layer (storage, drivers, …) priority-high High priority - will be reviewed soon labels Jun 12, 2024
@ronald-cron-arm ronald-cron-arm mentioned this pull request Jun 12, 2024
Merged
@gilles-peskine-arm
Copy link
Contributor

gilles-peskine-arm commented Jun 12, 2024

Conflicts with #9172 and the forward port of #9025. How close is this to completion? Can you wait until those two are done?

@ronald-cron-arm
Copy link
Contributor Author

ronald-cron-arm commented Jun 12, 2024 •
edited
Loading

Conflicts with #9172 and the forward port of #9025. How close is this to completion? Can you wait until those two are done?

I've already done some all.sh testing locally, and this is the first CI run. This is where I am.

Can you wait until those two are done?

Not really but this can be discussed.

gilles-peskine-arm
gilles-peskine-arm reviewed Jun 12, 2024
View reviewed changes
tf-psa-crypto/.gitignore
@@ -0,0 +1 @@
Makefile
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t<TAB> doesn't work anymore :( I don't know if there's a sensible solution.

Copy link
Contributor Author

@ronald-cron-arm ronald-cron-arm Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no you have to move to te<TAB>.

@ronald-cron-arm
all.sh: Fix clean-up of Makefiles generated by CMake
5cdc22b 
Signed-off-by: Ronald Cron <[email protected]>
@ronald-cron-arm
Add and update some .gitignore files
28ce238 
Signed-off-by: Ronald Cron <[email protected]>
@ronald-cron-arm
Move PSA headers
d80134b 
Move PSA headers to tf-psa-crypto
directory.

Signed-off-by: Ronald Cron <[email protected]>
gilles-peskine-arm added a commit to gilles-peskine-arm/mbedtls-docs that referenced this pull request Jun 12, 2024
@gilles-peskine-arm
Support framework after move of include/psa/*.h to tf-psa-crypto
2d9350d 
Support mbedtls after Mbed-TLS/mbedtls#9247

Signed-off-by: Gilles Peskine <[email protected]>

Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Jun 12, 2024
Open
@ronald-cron-arm
Adjust build systems
c7e9e36 
Adjust build systems such as we can build
Mbed TLS in the default and full configuration.

Signed-off-by: Ronald Cron <[email protected]>
@ronald-cron-arm
Adapt make apidoc
ebd153e 
Signed-off-by: Ronald Cron <[email protected]>
@ronald-cron-arm
Adapt make cscope
db9d518 
Signed-off-by: Ronald Cron <[email protected]>
@ronald-cron-arm
Adapt libraries installation
2581d91 
Signed-off-by: Ronald Cron <[email protected]>
@ronald-cron-arm
Adapt libtestdriver1 build
1451a76 
Signed-off-by: Ronald Cron <[email protected]>
@gilles-peskine-arm gilles-peskine-arm added priority-very-high Highest priority - prioritise this over other review work and removed priority-high High priority - will be reviewed soon labels Jun 13, 2024
@gilles-peskine-arm
Copy link
Contributor

gilles-peskine-arm commented Jun 13, 2024

As discussed this morning, we're prioritizing this pull request. #9172 and the forward port of #9025 are on hold until this is merged.

(But I'm reserving the next slot! Note that the forward port of #9025 is pretty complex and will take a while to do and review.)

@ronald-cron-arm
Copy link
Contributor Author

ronald-cron-arm commented Jun 13, 2024

(But I'm reserving the next slot! Note that the forward port of #9025 is pretty complex and will take a while to do and review.)

Hopefully we do not have to wait for this one for the next moves: mbedtls crypto headers, crypto C modules and crypto test suites.

@ronald-cron-arm ronald-cron-arm removed the needs-ci Needs to pass CI tests label Jun 13, 2024
@davidhorstmann-arm davidhorstmann-arm self-requested a review June 14, 2024 13:01
This was referenced Jun 14, 2024
Closed
Closed
Closed
Closed
davidhorstmann-arm
davidhorstmann-arm requested changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small point but LGTM otherwise!

@tom-daubney-arm tom-daubney-arm removed the needs-reviewer This PR needs someone to pick it up for review label Jun 17, 2024
tom-daubney-arm
tom-daubney-arm previously approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

davidhorstmann-arm
davidhorstmann-arm previously approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@davidhorstmann-arm davidhorstmann-arm added approved Design and code approved - may be waiting for CI or backports needs-backports Backports are missing or are pending review and approval. and removed needs-review Every commit must be reviewed by at least two team members, labels Jun 17, 2024
This was referenced Jun 18, 2024
Merged
Merged
@ronald-cron-arm
Copy link
Contributor Author

ronald-cron-arm commented Jun 18, 2024

@tom-daubney-arm @davidhorstmann-arm I've just pushed a last commit to update the framework to the merge of PR26.

@minosgalanakis minosgalanakis mentioned this pull request Jun 18, 2024
Merged
davidhorstmann-arm
davidhorstmann-arm approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tom-daubney-arm
tom-daubney-arm approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ronald-cron-arm ronald-cron-arm added this pull request to the merge queue Jun 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 18, 2024
@ronald-cron-arm
Merge pull request #9277 from ronald-cron-arm/tree-cleanliness-2.28
9250acc 
[Backport 2.28] Partial backport of #9247
Merged via the queue into Mbed-TLS:development with commit de0d7e6 Jun 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 19, 2024
@ronald-cron-arm
Merge pull request #9276 from ronald-cron-arm/tree-cleanliness-3.6
81a2d1d 
[Backport 3.6] Partial backport of #9247
@ronald-cron-arm ronald-cron-arm mentioned this pull request Jun 19, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm left review comments

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

+1 more reviewer

@tom-daubney-arm tom-daubney-arm tom-daubney-arm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Design and code approved - may be waiting for CI or backports component-psa PSA keystore/dispatch layer (storage, drivers, …) enhancement needs-backports Backports are missing or are pending review and approval. priority-very-high Highest priority - prioritise this over other review work

Projects

No open projects
Roadmap Board for Mbed TLS
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move Mbed TLS crypto headers to a new tf-psa-crypto directory

4 participants

@ronald-cron-arm @gilles-peskine-arm @davidhorstmann-arm @tom-daubney-arm