Unprinted signs at file loading

[Aluriak]

Hello !
If re-open a file where there are some bookmarks, the sign column is not printed. Bookmarks are still there, because its possible to jump to and see it in the show-all-bookmarks buffer.

vim version: 7.3.547
vim-bookmarks version: use of vundle for installation/update; so last one i think.
vimrc modifications:
nmap mt Annotate TODO:
nmap mi Annotate
nmap ml PrevBookmark
nmap mù NextBookmark
let g:bookmark_auto_save_file="/home/aluriak/.vim/vim-bookmarks"
let g:bookmark_center = 1
highlight SignColumn ctermbg=black
NB: savefile vim-bookmarks is in mode rwrwr.

[MattesGroeger]

Hi @Aluriak, thanks for the report. I will try to reproduce the issue.

[MattesGroeger]

Unfortunately I was not able to reproduce this problem. I assume you see the bookmarks once you place them. Do they already disappear if you re-open a closed buffer or do you have to start a new vim process to make them disappear?

It might be a different plugin interfering with vim-bookmarks. Which other plugins do you have installed?

[Aluriak]

yes, i see bookmarks when i place or replace them. If i place two bookmarks, close vim, reopen the file, there is no column. If i jump to next bookmark, i can found the lines where there are. If i remove one of them and place a new bookmark, the sign column appear, and print only the new bookmark.

I have to close vim and start a new vim process for make them disappear.

In my vimrc, i load each of these modules, in that order :
vim-scripts/pythoncomplete
derekwyatt/vim-scala
ktvoelker/sbt-vim
mdreves/vim-scaladoc
taglist.vim
scrooloose/nerdtree
scrooloose/nerdcommenter
tpope/vim-fugitive
terryma/vim-multiple-cursors
Shougo/neocomplcache
MattesGroeger/vim-bookmarks

taglist is the only local module. Others comes from github.

[MattesGroeger]

Ah you don't see the whole sign column. That is a hint, I'll try this later again. Thanks!

[nhuizing]

I have have a possible fix for this issue:

From d8215e7fd134de63c9f63ea0bbc910e31e672efc Mon Sep 17 00:00:00 2001
From: Nathan Huizinga <nathan.huizinga@gmail.com>
Date: Fri, 2 May 2014 12:21:41 +0200
Subject: [PATCH] Fix: vim-bookmark startup after loading the bookmarks reload
 the missing signs!

---
 vimfiles/bundle/vim-bookmarks/plugin/bookmark.vim | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/vimfiles/bundle/vim-bookmarks/plugin/bookmark.vim b/vimfiles/bundle/vim-bookmarks/plugin/bookmark.vim
index ac1f01f..16a9c6b 100644
--- a/vimfiles/bundle/vim-bookmarks/plugin/bookmark.vim
+++ b/vimfiles/bundle/vim-bookmarks/plugin/bookmark.vim
@@ -27,7 +27,7 @@ call s:set('g:bookmark_auto_save_file',   $HOME .'/.vim-bookmarks')
 if g:bookmark_auto_save ==# 1
   augroup bm_auto_save
     autocmd!
-    autocmd VimEnter * call LoadBookmarks(g:bookmark_auto_save_file, 1)
+    autocmd VimEnter * call s:startup_load_bookmarks(expand("<afile>:p"))
     autocmd VimLeave * call SaveBookmarks(g:bookmark_auto_save_file)
     autocmd BufWinEnter * call s:add_missing_signs(expand("<afile>:p"))
   augroup END
@@ -255,6 +255,11 @@ function! s:remove_all_bookmarks()
   endfor
 endfunction

+function! s:startup_load_bookmarks(file)
+   call LoadBookmarks(g:bookmark_auto_save_file, 1)
+   call s:add_missing_signs(a:file)
+endfunction
+
 " should only be called from autocmd!
 function! s:add_missing_signs(file)
   let bookmarks = values(bm#all_bookmarks_by_line(a:file))
-- 

[MattesGroeger]

Great, would you want to make a pull request? 👍

[Aluriak]

Thank you for help :)

[nhuizing]

I have added a pull request in issue #44.

[MattesGroeger]

Thanks for your contribution @nhuizing

[Aluriak]

Thanks for update and pull request, @MattesGroeger & @nhuizing :)