Skip to content

minimum and maximum value can also be negative values #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

Murmele
Copy link
Contributor

@Murmele Murmele commented Jan 5, 2023

Example:

BO_ 234 MSG1: 8 Vector__XXX
 SG_ Sig1 : 55|16@0- (0.1,0) [-3276.8|3276.7] "C" Vector__XXX
 SG_ Sig2 : 39|16@0- (0.1,0) [-3276.8|3276.7] "C" Vector__XXX
 SG_ Sig3 : 23|16@0- (0.1,0) [-3276.8|3276.7] "C" Vector__XXX
 SG_ Sig4 : 7|16@0- (1,0) [0|32767] "" Vector__XXX

@Murmele
Copy link
Contributor Author

Murmele commented Jan 5, 2023

@LinuxDevon

@LinuxDevon
Copy link
Owner

@Murmele looks good and thank you!
Looking over that string I should really change those to raw strings to make it look cleaner.

@LinuxDevon LinuxDevon merged commit c13d1fe into LinuxDevon:master Jan 5, 2023
@Murmele
Copy link
Contributor Author

Murmele commented Jan 6, 2023

@Murmele looks good and thank you! Looking over that string I should really change those to raw strings to make it look cleaner.

Yes maybe splitting up and the concatenating to one const string. I think the compiler will optimize it out then

@Murmele
Copy link
Contributor Author

Murmele commented Jan 6, 2023

@LinuxDevon if it is fine for you, I can do that because I found at least one more issues

@LinuxDevon
Copy link
Owner

@Murmele that is fine with me. Appreciate the help! I am planning on adding in an action to run the test suite on PR. If you don't mind can you add some more edge case test for those?

@Murmele
Copy link
Contributor Author

Murmele commented Jan 6, 2023

@LinuxDevon perfect I will create some tests next days

@Murmele Murmele deleted the negativeMinMax branch January 7, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants