Skip to content

Depend on upstream Cascade #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2023
Merged

Depend on upstream Cascade #1256

merged 1 commit into from
Oct 9, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Oct 8, 2023

Author did not want to upstream my changes. But they have included now the fix for the tonalElevation so we can depend on them now.

dessalines
dessalines approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Any PR that removes custom code is a great thing.

@dessalines dessalines merged commit 843e453 into LemmyNet:main Oct 9, 2023
@MV-GH MV-GH deleted the refactor/depend_on_upstream branch October 9, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines approved these changes

@twizmwazin twizmwazin Awaiting requested review from twizmwazin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MV-GH @dessalines