-
Notifications
You must be signed in to change notification settings - Fork 0
Array cardio1 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
return namestring; | ||
//console.log(namestring); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convert to ES6 syntax ie: .map(x => {}).
|
||
function firstandlastname (x){ | ||
const space = ' ' | ||
const namestring = x.first + space + x.last; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use string literal syntax please
function oldesttoyoungest(a,b){ | ||
return a.year-b.year; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
convert to ES6
|
||
function livetogether(totalyears, x){ | ||
return totalyears+ (x.passed - x.year); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. Please convert to ES6
@Laryl14 Good job!! Please address my comments before I can merge. Also, clean up code using camel case only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix camel case + other comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job cleaning up the code. LGTM
Solved all problems except for wesbos#6