Skip to content

Array cardio1 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 18, 2020
Merged

Array cardio1 #1

merged 13 commits into from
Feb 18, 2020

Conversation

Laryl14
Copy link
Owner

@Laryl14 Laryl14 commented Feb 9, 2020

Solved all problems except for wesbos#6

@Laryl14 Laryl14 requested a review from tebueno February 10, 2020 23:31
return namestring;
//console.log(namestring);
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert to ES6 syntax ie: .map(x => {}).


function firstandlastname (x){
const space = ' '
const namestring = x.first + space + x.last;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use string literal syntax please

function oldesttoyoungest(a,b){
return a.year-b.year;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convert to ES6


function livetogether(totalyears, x){
return totalyears+ (x.passed - x.year);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Please convert to ES6

@tebueno
Copy link
Collaborator

tebueno commented Feb 11, 2020

@Laryl14 Good job!! Please address my comments before I can merge. Also, clean up code using camel case only.

Copy link
Collaborator

@tebueno tebueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix camel case + other comments

Copy link
Collaborator

@tebueno tebueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job cleaning up the code. LGTM

@tebueno tebueno merged commit a272e51 into master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants