calculate seekdata in HTTP::open() is only timeOffset is provided #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like for File::open, there are cases where only the time offset of seek data is provided (e.g. when using a PlayList, Jump command with a seekdata, user wants a time not a bytes offset). We then must calculate, if possible, such offset right before sending the HTTP request. This did not happen when seeking as StreamingController::JumpToTime does the calculation. This worked with File::open because it does calculate the seekdata during open
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like for File::open, there are cases where only the time offset of seek data is provided (e.g. when using a PlayList, Jump command with a seekdata, user wants a time not a bytes offset). We then must calculate, if possible, such offset right before sending the HTTP request. This did not happen when seeking as StreamingController::JumpToTime does the calculation. This worked with File::open because it does calculate the seekdata during open