Skip to content

Conversation

@darrell-k
Copy link
Contributor

@michaelherger
Copy link
Member

Please provide more information in your PRs. It's really time consuming to find all the pieces in a lengthy discussion and an impossible code base. What is your change doing, under what circumstances to solve what problem?

@darrell-k
Copy link
Contributor Author

@CDrummond asked for extra data at the top level of the response for track lists, to identify it as an album track listing, and to provide the album name, artist, year and genre.

@michaelherger
Copy link
Member

What does it mean "at the top level of the response"? Would this be eg. part of a "tracks 0 10 album_id:xyz" type query? And is it really good enough to have this for albums? Wouldn't we want to have that for all kinds of "container" elements, like works, podcasts etc.?

@darrell-k
Copy link
Contributor Author

At the moment, the response json result structure is:

base{
->actions:{...}
->count:n
->item_loop:[...]
->offset:n
->title:"album-name"
->window:{...}
}

This change will result in:

base{
->album:"album-name"
->artist:"artist-name"
->actions:{...}
->count:n
->genre:"genre"
->hasMetadata:"album"
->item_loop:[...]
->offset:n
->title:"album-name"
->window:{...}
->year:"yyyy"
}

Something similar may be needed for other types of list, but that has not been identified yet. I'm about to add a commit to include the "hasMetadata" element whenever present.

I see this branch as incremental additions to the code as we work through the development with Craig .

@michaelherger
Copy link
Member

Ok, got it, thanks!

@michaelherger michaelherger merged commit c52c784 into LMS-Community:SlimBrowse-Metadata Jun 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants