[Bug]: Sanctified items

[Kvan7]

FAQ

• I have checked the FAQ, Common Issues, and for existing issues and my problem was not there

Common Bugs

Not Recognized Modifier

What happened?

Sanctified text shows up.

This will also require adding a prop to ParsedItem for "isSanctified". then also adding an or based on "isSanctified" to "likelyFinishedItem"

Version

0.11.5

Item Copy text

Relevant log output

[test137E29B]

@Kvan7 Looking into this in Exiled Exchange, a lot of places use isCorrupted from the item details to determine rune sockets, quality increase etc. that aren't possible because the item is corrupted. Sanctified items share the same inability to be crafted further by most methods, but the changes would involve adding isSanctified to every place isCorrupted is used.

The other option is using a new isUncraftable alongside corrupted and sanctified so we can still show the correct sanct / corrupt tag in the UI, and search for the correct filter too. isUnmodifiable already exists but is only used when specifically the copy text includes Unmodifiable as text - so probably means something different?

If you have any other info I'll gladly listen so I can take a crack at adding this one today :)

[Kvan7]

So isUnmodifiable was meant to be used with items like: https://www.poewiki.net/wiki/Censer_Relic in poe1

Which is mainly to refer to items that cannot be crafted on and were never able to be crafted on. We don't have any items like this in poe 2 yet as far as i know.

---

For all the options we have for this:

• isCorrupted
• isUnmodifiable
• isMirrored

Sanctified is most closely related to isMirrored. but we don't want to really ever set the sanctified filter on the trade site, except setting Sanctified to NO when we are searching an item with opts.exact (since this is usually for crafting). (edit: reason we don't want to set sanctified unless opts.exact while we are fine with setting mirrored to false nearly always is since sanctified items can potentially be better than normal items, while mirrored are exactly just normal items)

double edit: you are right this is actually much closer to Corrupted since it is, for all intents and purposes, just corrupting it but with a specific given outcome

For mirrored items we set it to false unless the item itself is mirrored

Exiled-Exchange-2/renderer/src/web/price-check/trade/pathofexile-trade.ts

Lines 480 to 488 in 5c2adf6

	if (filters.mirrored) {
	if (filters.mirrored.disabled) {
	propSet(
	query.filters,
	"misc_filters.filters.mirrored.option",
	String(false),
	);
	}
	} else if (

I think the best action would be to add isSanctified to the item and parse for it, in case there is some use in the future for sanctified items specifically.

Then add a function to ParsedItem, that will check if we are able to craft on an item. This function will then replace most instances where we do a check for if the item is Mirrored or Corrupted with that function. This won't include the isUnmodifiable field since those items were never craftable to begin with.
ex:

Exiled-Exchange-2/renderer/src/web/price-check/filters/create-stat-filters.ts

Line 269 in 5c2adf6

if (!item.isCorrupted && !item.isMirrored) {

or

Exiled-Exchange-2/renderer/src/web/price-check/filters/pseudo/anointments.ts

Line 63 in 5c2adf6

} else if (!item.isCorrupted && !item.isMirrored) {

[test137E29B]

That's a good approach with the extra function to check - I'd definitely keep isSanctified purely for now just to have the tag in the UI show SANCTIFIED where normally CORRUPTED shows (also so that we can add the filter in trade for sanctified items only)

I'll be a little busy with work for the next week or so, but if this still exists towards next weekend I'll take a look into it then. Otherwise feel free to have at it! :)