Add support for SPV_KHR_compute_shader_derivative #5817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
alan-baker
requested changes
Sep 24, 2024
Contributor
alan-baker
left a comment
alan-baker
left a comment
There was a problem hiding this comment.
Just a small change to the allow lists in optimization passes.
alan-baker
approved these changes
Sep 24, 2024
dneto0
approved these changes
Sep 24, 2024
Contributor
|
It looks like you missed a few test updates. Try |
Contributor
|
Please fix the formatting. |
Contributor
I fixed this. |
Keenuts
pushed a commit
to Keenuts/SPIRV-Tools
that referenced
this pull request
Nov 12, 2024
* Add support for SPV_KHR_compute_shader_derivative * Update tests for SPV_KHR_compute_shader_derivatives --------- Co-authored-by: MagicPoncho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace support for SPV_NV_compute_shader_derivatives with the new KHR (many lists had the vendor extension twice, replace one with the new KHR).