libspirv.cpp: adds c++ api for spvBinaryParse #5109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a C++ wrapper above the current spvBinaryParse function. I tried to match it 1:1, except for 2 things: - std::function<>& are used. No more function pointers, allowing context capture. - spv_result_t replaced with a boolean, to match other C++ apis. Callbacks still return a spv_result_t because the underlying implem relies on that. The convertion from spv_result_t to boolean is only done at the boundary. Signed-off-by: Nathan Gauër <[email protected]>
s-perron
previously approved these changes
Feb 14, 2023
Collaborator
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
This looks great thanks. Just a few minor nits, and then it is good to merge.
s-perron
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a C++ wrapper above the current spvBinaryParse function. I tried to match it 1:1, except for 2 things:
Callbacks still return a spv_result_t because the underlying implem relies on that. The convertion from spv_result_t to boolean is only done at the boundary.