-
Notifications
You must be signed in to change notification settings - Fork 37
Add overapproximate
for exponential map for SPZ and Zonotope
#3979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Christian Schilling <[email protected]>
d6947ab
to
09a5865
Compare
thats very nice! |
Co-authored-by: Christian Schilling <[email protected]>
…ts.jl into alecarraro/prop3_lkb23
Co-authored-by: Christian Schilling <[email protected]>
7891d54
to
fff5c3e
Compare
fix factorial, index variable, docstring and early return of `exponential_map` changed docstring for `_compute_inner_powers` fix docstring for `taylor_expmap_remainder` change `P` to `Z` in `taylor_expmap_remainder` fix argument in `taylor_exp_remainder`
9d2c44c
to
ea44143
Compare
With the new code changes, the sets are actually identical already for κ = 2. I was first surprised because I expected the approximation to get coarser with the fixes. But then I realized that this happens because you now handle this case exactly. So the example above is not a good benchmark anymore 😅 |
Modifying the example slightly, MZ = MatrixZonotope(M, [N[0 0; 0 0]]) i.e., adding a zero generator to the MZ, does not trigger the shortcut. So it uses the proper approximation, and I get basically the same results as before. |
@alecarraro Is this ready to be merged? |
Yes, I implemented all the feedback from your reviews. I tested the reachability algorithm to test a real use case of these methods and it works . |
Implement proposition of LKB23