Skip to content

Conversation

alecarraro
Copy link
Collaborator

@alecarraro alecarraro commented Jul 27, 2025

I added the implementation of Proposition 1 from LKB23, that is the exact linear_map of matrix zonotopes with sparse polynomial zonotopes with no independent generators
I also added Proposition 4 from Althoff 2021, the overapproximation linear_map of matrix zonotopes with zonotopes, which is needed for proposition 2 in LKB23

@schillic schillic changed the title Add linear map between MatrixZonotope and `SPZ Add linear map between MatrixZonotope and SPZ Jul 28, 2025
Apply suggestions from code review

Co-authored-by: Christian Schilling <[email protected]>
@alecarraro alecarraro force-pushed the alecarraro/prop_1_2_lkb branch from 1bd2b2e to b61c8e7 Compare July 28, 2025 08:41
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overapproximate code looks good (only minor renaming suggestions).
Still need to check the linear_map code.
EDIT: There is also an old suggestion above.

Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linear_map also looks good after minor suggestions!

@alecarraro
Copy link
Collaborator Author

should I move the AbstractMatrixZonotope in an interface file and move it before validate in LazySets.jl?

@schillic
Copy link
Member

schillic commented Jul 28, 2025

It is not that easy because it is inside a module. I think it is not worth doing that for now.

EDIT: I also prefer to keep the matrix sets in that module.

@schillic schillic changed the title Add linear map between MatrixZonotope and SPZ Add linear_map between MatrixZonotope and SPZ Jul 28, 2025
@schillic schillic merged commit ff75368 into master Jul 28, 2025
7 checks passed
@schillic schillic deleted the alecarraro/prop_1_2_lkb branch July 28, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants