-
Notifications
You must be signed in to change notification settings - Fork 37
Add linear_map
between MatrixZonotope
and SPZ
#3969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Christian Schilling <[email protected]>
MatrixZonotope
and `SPZMatrixZonotope
and SPZ
Apply suggestions from code review Co-authored-by: Christian Schilling <[email protected]>
1bd2b2e
to
b61c8e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overapproximate
code looks good (only minor renaming suggestions).
Still need to check the linear_map
code.
EDIT: There is also an old suggestion above.
Co-authored-by: Christian Schilling <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linear_map
also looks good after minor suggestions!
Co-authored-by: Christian Schilling <[email protected]>
should I move the |
It is not that easy because it is inside a module. I think it is not worth doing that for now. EDIT: I also prefer to keep the matrix sets in that module. |
MatrixZonotope
and SPZ
linear_map
between MatrixZonotope
and SPZ
I added the implementation of Proposition 1 from LKB23, that is the exact
linear_map
of matrix zonotopes with sparse polynomial zonotopes with no independent generatorsI also added Proposition 4 from Althoff 2021, the overapproximation
linear_map
of matrix zonotopes with zonotopes, which is needed for proposition 2 in LKB23