Skip to content

Add methods and type for MatrixSets #3966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 27, 2025
Merged

Add methods and type for MatrixSets #3966

merged 10 commits into from
Jul 27, 2025
+303 −44

Conversation

alecarraro
Copy link
Collaborator

@alecarraro alecarraro commented Jul 26, 2025 •
edited by schillic
Loading

This is the first of a sequence of 3/4 pull requests to implement the overapproximation methods for maps with matrix zonotopes. In this PR i implement

  • An AbstractMatrixZonotope supertype
  • A MatrixZonotopeProduct type to store lazy products of matrix zonotopes
  • A MatrixZonotopeExp to represent lazily the exponential $\exp(\mathcal{A})$
  • overapproximate_norm and remove_redundant_factors for MatrixZonotopeProduct
  • linear_map for MatrixZonotope

@schillic
Copy link
Member

Could you add a separate PR for fixing scale, including a test?

@alecarraro
Copy link
Collaborator Author

Could you add a separate PR for fixing scale, including a test?

Done. Should I undo the commit in this one then?

@schillic
Copy link
Member

Yes - there will be a merge conflict sooner or later anyway.

@schillic
Copy link
Member

Still a conflict here...

schillic
schillic reviewed Jul 27, 2025
View reviewed changes
schillic
schillic reviewed Jul 27, 2025
View reviewed changes
src/MatrixSets/MatrixZonotopeProduct.jl Outdated
reduced = MatrixZonotope{eltype(factors_[1]), typeof(center(factors_[1]))}[]

i = 1
while i < length(factors_)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be turned into a normal for loop. Is that intended? See also the next comment.

src/MatrixSets/MatrixZonotopeProduct.jl Outdated
end

# in the last element apply linear map to the left
if i == length(factors_)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition always holds.

src/MatrixSets/MatrixZonotopeProduct.jl Outdated
end
end
if isempty(reduced)
return center(factors_[end-1]) # return concrete matrix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why end-1?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, this was added to fix an edge case, but it actually breaks others. I will edit it and add more corner tests

src/MatrixSets/MatrixZonotopeProduct.jl Outdated
while i < length(factors_)
MZ = factors_[i]
if isempty(generators(MZ))
factors_[i+1] = linear_map(center(MZ), factors_[i + 1])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand this code. This function should not modify factors_.

@alecarraro @schillic
Apply suggestions from code review
73937d1 
Co-authored-by: Christian Schilling <[email protected]>
@schillic
Copy link
Member

Apart from remove_redundant_factors I can approve this PR. I have the feeling that remove_redundant_factors will take a bit longer to discuss. Do you want to move it to a separate PR so we can merge this? (Up to you.)

@alecarraro
Copy link
Collaborator Author

yes lets move it to a different PR,

@alecarraro
Copy link
Collaborator Author

alecarraro commented Jul 27, 2025 •
edited
Loading

I removed all the appearence of remove_redundant_factors from this PR and created a new branch for that. i will update the function and create a new PR later

@schillic schillic merged commit 458fb29 into master Jul 27, 2025
7 checks passed
@schillic schillic deleted the alecarraro/LM_mz branch July 27, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alecarraro @schillic