Add merge_id and generalize exact_sum for SPZ
#3905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillic
reviewed
Jul 6, 2025
alecarraro
force-pushed
the
alecarraro/merge_scale
branch
2 times, most recently
from
12bbd9d to
ab551eb
Compare
alecarraro
force-pushed
the
alecarraro/merge_scale
branch
from
ab551eb to
baf22f7
Compare
alecarraro
changed the title
scale and merge_id functions for SPZmerge_id functions for SPZ
schillic
reviewed
Jul 6, 2025
src/Sets/SparsePolynomialZonotope/SparsePolynomialZonotopeModule.jl
Outdated
Show resolved
Hide resolved
src/Sets/SparsePolynomialZonotope/SparsePolynomialZonotopeModule.jl
Outdated
Show resolved
Hide resolved
schillic
reviewed
Jul 6, 2025
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
|
I agree with all the suggestions, but one, see my comment above. |
schillic
reviewed
Jul 6, 2025
src/Sets/SparsePolynomialZonotope/SparsePolynomialZonotopeModule.jl
Outdated
Show resolved
Hide resolved
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
Co-authored-by: Christian Schilling <[email protected]>
schillic
reviewed
Jul 6, 2025
Co-authored-by: Christian Schilling <[email protected]>
schillic
approved these changes
Jul 7, 2025
schillic
changed the title
merge_id for SPZmerge_id and generalize exact_sum for SPZ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: I added the corrected
merge_idfunction, including tests and documentation. I also revisitedexact_sumfunction for SPZ to handle SPZs with differingindexVectors using themerge_idfunctions