Skip to content

Fixes for Universe #3807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 9, 2025
Merged

Fixes for Universe #3807

merged 8 commits into from
Feb 9, 2025

Conversation

schillic
Copy link
Member

@schillic schillic commented Feb 8, 2025

  • let diameter for Universe throw ArgumentError
  • let norm for Universe throw ArgumentError
  • let radius for Universe throw ArgumentError
  • add volume for Universe
  • add input validation to affine_map
  • change input validation for linear_map to assertion and move
  • let permute for Universe validate inputs
  • let project for Universe validate inputs

@schillic schillic marked this pull request as ready for review February 9, 2025 06:45
@schillic schillic merged commit 9a4ea76 into master Feb 9, 2025
7 checks passed
@schillic schillic deleted the schillic/Universe_fixes branch February 9, 2025 06:45
@schillic schillic mentioned this pull request Feb 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@schillic