Rename and export delaunay and triangulate
#3804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mforets
approved these changes
Feb 14, 2025
|
This needs to be reworked: the plan is to rename |
schillic
force-pushed
the
schillic/delaunay
branch
from
e399be5 to
535c6c3
Compare
schillic
force-pushed
the
schillic/delaunay
branch
from
535c6c3 to
5d6ea82
Compare
schillic
changed the title
delaunay and triangulate a default symboldelaunay and triangulate
mforets
approved these changes
Apr 17, 2025
Merged
schillic
referenced
this pull request
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
triangulatetotriangulate_facesanddelaunaytotriangulate, always exports these functions, and addstriangulate(new name) methods forEmptySetandUniverseto get a useful error message.Commits
delaunayandtriangulatea default (exported) function. The benefits are that there is now an error message informing which package to load and that it is possible to define methods even whenMiniQhull/Polyhedraare not loaded.delaunaymethods forEmptySetandUniverse.This PR is mildly breaking: whenusing MiniQhull, there is now a name clash withdelaunay.import MiniQhullstill works. I argue that most users do not need theusingversion.triangulatetotriangulate_faces.delaunaytotriangulate.