Skip to content

Revise tests for EmptySet #3800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2025
Merged

Revise tests for EmptySet #3800

merged 1 commit into from
Feb 8, 2025

Conversation

schillic
Copy link
Member

@schillic schillic commented Feb 8, 2025 •
edited
Loading

This is a revision of the test structure introduced in #3672.

Main changes:

  • guard tests that require external packages
  • define isidentical shorthand
  • test additional functions (constrained_dimensions, triangulate, linear_map_inverse)
  • identify validation bug in exponential_map
  • identify validation bug in ≈
  • do not test length of witness vectors (assumed to be done in membership test)
  • define common set E3 only once

@schillic schillic marked this pull request as ready for review February 8, 2025 10:33
@schillic schillic merged commit caa28eb into master Feb 8, 2025
7 checks passed
@schillic schillic deleted the schillic/emptyset_tests branch February 8, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@schillic