Skip to content

#3629 - Fix intersection of LineSegments #3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 25, 2024
Merged

#3629 - Fix intersection of LineSegments #3630

merged 6 commits into from
Aug 25, 2024

Conversation

schillic
Copy link
Member

Closes #3629.

The old code from #2138 was not correct. This PR adds a simple but non-optimized fix in the same spirit.

This works now:

LS1 = LineSegment(Float32[-34.67, -46.06], Float32[-13.03, -49.77]);
LS2 = LineSegment(Float32[-22.473152, -48.13686], Float32[-19.031397, -48.730015]);
intersection(LS1, LS2)

@schillic schillic mentioned this pull request Jul 30, 2024
Closed
@schillic schillic marked this pull request as ready for review July 30, 2024 10:36
Wikunia
Wikunia reviewed Jul 30, 2024
View reviewed changes
Wikunia
Wikunia reviewed Jul 31, 2024
View reviewed changes
schillic
schillic commented Jul 31, 2024
View reviewed changes
Wikunia
Wikunia reviewed Jul 31, 2024
View reviewed changes
@schillic schillic merged commit 73aec8e into master Aug 25, 2024
7 checks passed
@schillic schillic deleted the schillic/3629 branch August 25, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

+1 more reviewer

@Wikunia Wikunia Wikunia left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong intersection of line segments
3 participants
@schillic @Wikunia @mforets