Skip to content

#3495 - Avoid repeated creation of zero_box/sym_box #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2024
Merged

#3495 - Avoid repeated creation of zero_box/sym_box #3609

merged 1 commit into from
Sep 9, 2024

Conversation

schillic
Copy link
Member

@schillic schillic commented Jul 23, 2024 •
edited
Loading

Closes #3495.

@schillic schillic marked this pull request as ready for review July 23, 2024 11:06
@schillic schillic changed the title avoid repeated creation of zero_box/sym_box Avoid repeated creation of zero_box/sym_box Jul 23, 2024
@schillic schillic changed the title Avoid repeated creation of zero_box/sym_box #3495 - Avoid repeated creation of zero_box/sym_box Jul 23, 2024
mforets
mforets approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but im not sure if this has any perf benefits? Not easy to measure in an actual example, as the difference might be quite small.

@schillic schillic merged commit b83c892 into master Sep 9, 2024
@schillic schillic deleted the schillic/3495 branch September 9, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use only one interval instance for zero_itv / sym_itv
2 participants
@schillic @mforets