Skip to content

Conversation

schillic
Copy link
Member

@schillic schillic commented Jul 7, 2024

julia> X = Line([0.0, 1.0], [-1.0, 1.0]);

julia> box_approximation(X)  # master
Hyperrectangle{Float64, Vector{Float64}, Vector{Float64}}([NaN, NaN], [Inf, Inf])

julia> box_approximation(X)  # this branch
ERROR: ArgumentError: the box approximation of an unbounded set is undefined

@schillic schillic marked this pull request as ready for review July 7, 2024 05:03
@schillic schillic force-pushed the schillic/box_approximation branch from 47f7188 to 8a3af7d Compare August 24, 2024 06:11
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@schillic schillic added the breaking ❌ This change may break things label Sep 7, 2024
@schillic schillic merged commit a6f15cd into master Sep 7, 2024
5 of 6 checks passed
@schillic schillic deleted the schillic/box_approximation branch September 7, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking ❌ This change may break things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants