Skip to content

Conversation

@t-bltg
Copy link
Member

@t-bltg t-bltg commented Aug 10, 2022

  • rename ascii_display to ascii_show since we write to an io (low level, thus more consistent with ImageInTerminal/src/display.jl);
  • fix downscaling for ReferenceTests.jl;
  • update docstrings;
  • increase coverage.

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #8 (88aff27) into master (4bd5466) will increase coverage by 6.66%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master        #8      +/-   ##
===========================================
+ Coverage   93.33%   100.00%   +6.66%     
===========================================
  Files           2         2              
  Lines         135       143       +8     
===========================================
+ Hits          126       143      +17     
+ Misses          9         0       -9     
Impacted Files Coverage Δ
src/ascii.jl 100.00% <100.00%> (+6.03%) ⬆️
src/colorant2ansi.jl 100.00% <100.00%> (+10.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@t-bltg t-bltg force-pushed the ref_tests branch 11 times, most recently from db7c4bd to e2833d1 Compare August 11, 2022 09:11
@t-bltg t-bltg marked this pull request as draft August 11, 2022 09:42
@t-bltg
Copy link
Member Author

t-bltg commented Aug 11, 2022

Just fixing a regression an ambiguity in encoding detected by coverage, before we can merge this.

@t-bltg t-bltg marked this pull request as ready for review August 11, 2022 09:54
@t-bltg t-bltg merged commit c988dc2 into JuliaImages:master Aug 11, 2022
@t-bltg t-bltg deleted the ref_tests branch August 11, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants