Skip to content

Add AsciiPixel backend #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
johnnychen94 wants to merge 4 commits into from
Closed

Add AsciiPixel backend #61

johnnychen94 wants to merge 4 commits into from

Conversation

@johnnychen94
Copy link
Member

@johnnychen94 johnnychen94 commented Jan 2, 2022 •
edited
Loading

This is the second patchset from #58

To make changes as small as possible, I dropped some changes from #58:

  • unnecessary style changes like c*256 -> 256c are dropped
  • struct renaming TermColor256 -> TermColor8bit is dropped; we can just add const TermColor8bit = TermColor256 if needed

t-bltg added 2 commits January 2, 2022 08:58
@t-bltg @johnnychen94
CI(UnitTest): replace Julia 1.0 with 1.6
e3eafce 
Except for the simplification and template upgrades, there are two
worth-noting changes in this commit:

- replaces Julia 1.0 with Julia 1.6 (the new LTS version).
- only test windows/macOS on Julia 1
@t-bltg @johnnychen94
initialize AsciiPixel project
795418b
@johnnychen94
move colorant2ansi from ImageInTerminal to AsciiPixel
248d381 
Except for small simplification on tests, this commit introduces no
functionality changes.
@johnnychen94
refactor(AsciiPixel): make TermColor256/TermColor24bit functor
1869d21 
`colorant2ansi` is deprecated in favor of the functor API.
@johnnychen94
Copy link
Member Author

johnnychen94 commented Jan 3, 2022

@t-bltg I'm taking this as an opportunity to rewrite for a better codebase (docs, performance, usability, API), so it might take a few days more here.

@t-bltg
Copy link
Member

t-bltg commented Jan 3, 2022

@t-bltg I'm taking this as an opportunity to rewrite for a better codebase (docs, performance, usability, API), so it might take a few days more here.

Perfect, no hurry 👍

Base automatically changed from jc/ci to master January 17, 2022 17:16
@t-bltg t-bltg closed this Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johnnychen94 @t-bltg