Skip to content

Conversation

cstruct
Copy link
Contributor

@cstruct cstruct commented Jul 26, 2025

This is a rebased version of #108. I accidentally did a cherry-pick so I did not get a separate merge commit as I intended, I can redo it if @kcking or @termoshtt wants me to.

@termoshtt termoshtt self-requested a review July 30, 2025 05:10
@termoshtt
Copy link
Member

OK, I understand that PyO3 simply translates Rust's impl Future to Python's Coroutine object by converting Python's coroutine.send to Rust's Future::poll and so on. Thus, it is enough to add async marker on stub file as our task.

Copy link
Member

@termoshtt termoshtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@termoshtt termoshtt merged commit 1870f63 into Jij-Inc:main Aug 2, 2025
25 checks passed
@kcking
Copy link
Contributor

kcking commented Aug 2, 2025

Hey thanks a bunch for getting this across the line!

@cstruct cstruct deleted the async-fn branch August 2, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants