Skip to content

Show all supported terminals in OpenInTerminalLite first-launch prompt #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jnross wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Show all supported terminals in OpenInTerminalLite first-launch prompt #242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions OpenInTerminalCore/AppManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,20 @@ public class AppManager {
// Add button and avoid the focus ring
let cancelString = NSLocalizedString("general.cancel", comment: "Cancel")
alert.addButton(withTitle: cancelString).refusesFirstResponder = true
alert.addButton(withTitle: SupportedApps.terminal.name).refusesFirstResponder = true
alert.addButton(withTitle: SupportedApps.iTerm.name).refusesFirstResponder = true
alert.addButton(withTitle: SupportedApps.hyper.name).refusesFirstResponder = true

let terminals = Array(SupportedApps.terminals.reversed())
for app in terminals {
alert.addButton(withTitle: app.name).refusesFirstResponder = true
}
let modalResult = alert.runModal()
switch modalResult {
case .alertFirstButtonReturn:
return nil
case .alertSecondButtonReturn:
return SupportedApps.terminal.app
case .alertThirdButtonReturn:
return SupportedApps.iTerm.app
default:
return SupportedApps.hyper.app

let selectedAppIndex = modalResult.rawValue - NSApplication.ModalResponse.alertSecondButtonReturn.rawValue

if selectedAppIndex >= 0 && selectedAppIndex < terminals.count {
let selectedApp = terminals[selectedAppIndex].app
return selectedApp
}
return nil
}

public func pickEditorAlert() -> App? {
Expand Down