Skip to content

feat: move menu items to submenu #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsingll wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: move menu items to submenu #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions OpenInTerminalFinderExtension/FinderSync.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,20 @@ class FinderSync: FIFinderSync {
func createDefaultMenu() -> NSMenu {
let menu = NSMenu(title: "")

// 添加一级菜单项
let menuItem = NSMenuItem(title: "Open in...", action: nil, keyEquivalent: "")

// 创建二级菜单
let subMenu = NSMenu(title: "")

guard let terminal = DefaultsManager.shared.defaultTerminal else { return menu }
let terminalTitle = terminal.name
let openInTerminalItem = NSMenuItem(title: terminalTitle,
action: #selector(openDefaultTerminal),
keyEquivalent: "")
let terminalIcon = DefaultsManager.shared.getAppIcon(terminal)
openInTerminalItem.image = terminalIcon
menu.addItem(openInTerminalItem)
subMenu.addItem(openInTerminalItem)

guard let editor = DefaultsManager.shared.defaultEditor else { return menu }
let editorTitle = editor.name
Expand All @@ -123,10 +129,15 @@ class FinderSync: FIFinderSync {
keyEquivalent: "")
let editorIcon = DefaultsManager.shared.getAppIcon(editor)
openInEditorItem.image = editorIcon
menu.addItem(openInEditorItem)
subMenu.addItem(openInEditorItem)

// add "Copy Path"
menu.addItem(self.copyPathItem)
subMenu.addItem(self.copyPathItem)

// 将二级菜单关联到一级菜单项
menuItem.submenu = subMenu

menu.addItem(menuItem)

return menu
}
Expand Down