Skip to content

Update WIN32 ifdef checks to _MSC_VER #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harryr0se
Copy link

These code paths are wrapped with windows platform #ifdef checks but appear to be more specific to the compiler
Making these changes means I can compile with both MSVC and GCC (via MinGW) on Windows

Also just want to check, does us skipping this buffer clearing step on other compilers cause any issues?
I don't have a good idea of the lifetime of the error_strbuf object

// Make sure our buffer is empty
#ifdef _MSC_VER
    _Tidy();
#endif

@JBenda
Copy link
Owner

JBenda commented May 18, 2025

Good catch, thanks for fixing it.

The _Tidy() has no implications for executing it under normal circumstances.

I need to dig in again, I think it was some platform specific magic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants