Update WIN32 ifdef checks to _MSC_VER #114
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These code paths are wrapped with windows platform
#ifdef
checks but appear to be more specific to the compilerMaking these changes means I can compile with both MSVC and GCC (via MinGW) on Windows
Also just want to check, does us skipping this buffer clearing step on other compilers cause any issues?
I don't have a good idea of the lifetime of the
error_strbuf
object