feat(bloomfilter): add salt #742
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenkokke
requested review from
dcoutts,
jorisdral,
mheinzel and
recursion-ninja
as code owners
wenkokke
force-pushed
the
wenkokke/bloomfilter-salt
branch
from
559e85f to
08445e8
Compare
dcoutts
requested changes
May 29, 2025
Comment on lines
+95
to
+104
| update s (hashSalt64 salt x) | ||
|
|
||
| instance (Hashable a, Hashable b) => Hashable (a, b) where | ||
| hashSalt64 salt (x, y) = incrementalHash salt $ \s -> do | ||
| update s (hash64 x) | ||
| update s (hash64 y) | ||
| update s (hashSalt64 salt x) | ||
| update s (hashSalt64 salt y) |
There was a problem hiding this comment.
You don't need to change these ones that use incrementalHash, because incrementalHash already uses the salt to initialise the (mutable) hash state.
There was a problem hiding this comment.
Yes, I was wondering about that.
There was a problem hiding this comment.
Does it hurt, though?
wenkokke
force-pushed
the
wenkokke/bloomfilter-salt
branch
from
a0d8b27 to
caeb000
Compare
wenkokke
force-pushed
the
wenkokke/bloomfilter-salt
branch
3 times, most recently
from
4752a95 to
35e8db0
Compare
wenkokke
force-pushed
the
wenkokke/bloomfilter-salt
branch
from
2fc1622 to
f13d95b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds salt to the Bloom filter API.
I expect the CI to break, since I have not modified the usage of the bloomfilter package in lsm-tree.