Skip to content

feat: respect be network body limit #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 1, 2025
Merged

Conversation

kholood-ea
Copy link
Contributor

Description of the change

Respect network body limit from the BE

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JiraID:18482

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@InstabugCI
Copy link
Collaborator

InstabugCI commented May 27, 2025

Warnings
⚠️ Coverage for JavaScript is less than the expected threshold of 90%

Coverage Report

Label Coverage Status
JavaScript 88.3%
Android 50.3%
iOS 46.7%

Generated by 🚫 dangerJS against 7c45a0f

AyaMahmoud148
AyaMahmoud148 previously approved these changes May 28, 2025
MoKamall
MoKamall previously approved these changes Jun 1, 2025
Copy link
Contributor

@AndrewAminInstabug AndrewAminInstabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kholood-ea Great effort 👏👏 ... kindly check the minor comments

@kholood-ea kholood-ea merged commit c668f3b into dev Jul 1, 2025
10 of 12 checks passed
@kholood-ea kholood-ea deleted the feat/respect-BE-network-body-limit branch July 1, 2025 12:59
kholood-ea added a commit that referenced this pull request Jul 1, 2025
* chore(ios): add respect BE network body limit custom build

* feat(ios): add getNetworkBodyMaxSize API

* feat:add getNetworkBodyMaxSize API

* chore(android): add respect network body limit snapshot

* chore(ios): sync pdfile.lock

* Revert "Merge pull request #1388 from Instabug/refactor/replace-reflection"

This reverts commit 256e72a, reversing
changes made to 196b481.

* feat(android): add getNetworkBodyMaxSize API

* feat:add feature flag change listener for android

* chore: fix sync_generated_files CI job

* feat(ios): add getNetworkBodyMaxSize API

* chore: add change log

* Revert duplicate "feat(ios): add getNetworkBodyMaxSize API"

This reverts commit ef8710e.

* chore: edit a change log

* chore: update test cases titles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants